fix clearing browsing history on shutdown #2025
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This user.js clears some data on exit, but is not intending to clear browsing history on exit. I am referring to these lines in the user.js:
However, for some reason, the actual behavior is that the browsing history is deleted on shutdown.
How to reproduce:
rm prefs.jsThe fix:
Here is how I found the fix:
rm prefs.jscp prefs.js prefs.js.tmpdiff prefs.js prefs.js.tmpObserve that Firefox added the line
among others.
After I added this line to my user.js, I deleted prefs.js again and now the "Browsing & download history" checkbox is unchecked as expected and the browsing history is not deleted anymore.
I dont know, but maybe not everybody runs into this problem, because maybe
is set in the prefs.js for most people?